Skip to content

Fix: type confliction if using WiFi and ETH - #147

Merged
hideakitai merged 3 commits into
mainfrom
fix/type-confliction-if-using-eth
Oct 17, 2025
Merged

Fix: type confliction if using WiFi and ETH#147
hideakitai merged 3 commits into
mainfrom
fix/type-confliction-if-using-eth

Conversation

@hideakitai

Copy link
Copy Markdown
Owner

@hideakitai
hideakitai requested a review from Copilot October 17, 2025 14:29
@hideakitai hideakitai self-assigned this Oct 17, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Introduces a wrapper UDP type (ETHUdp) to eliminate template/type conflicts when using both WiFi and Ethernet ArtNet managers concurrently, and adds a combined send/receive example for WiFi + Ethernet.

  • Defines ETHUdp (deriving from WiFiUDP) and updates template specializations and aliases to use it.
  • Adds a new example demonstrating simultaneous WiFi and Ethernet ArtNet send/receive.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
ArtnetETH.h Adds ETHUdp type and updates specializations/aliases to avoid WiFi/Ethernet UDP type conflicts.
examples/Multiple/send_receive_eth/send_receive_eth.ino New example showing concurrent WiFi and Ethernet ArtNet usage.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread ArtnetETH.h
Comment thread ArtnetETH.h
Comment thread examples/Multiple/send_receive_eth/send_receive_eth.ino
Comment thread examples/Multiple/send_receive_eth/send_receive_eth.ino
Base automatically changed from fix/millis-overflow to main October 17, 2025 14:35
@hideakitai
hideakitai merged commit a745940 into main Oct 17, 2025
28 checks passed
@hideakitai
hideakitai deleted the fix/type-confliction-if-using-eth branch October 17, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants