Oracle TimesTen Dialect for Hibernate 6.6 Updates #10492

carlblan · 2025-07-08T21:48:41Z

Some updates from an Oracle employee to the Oracle TimesTen Community dialect. ( Hibernate 6.6 )

In TimesTenDialect.java

Adding more datatypes into columnType()
Added more SQL functions support into initializeFunctionRegistry()
Updated the custom definition for 'getForUpdateString()'
Added a custom definition for 'getNativeIdentifierGeneratorStrategy()'
Added a custom definition for 'currentDate()'
Added a custom definition for 'currentTime()'
Added a custom definition for 'getMaxVarcharLength()'
Added a custom definition for 'getMaxVarbinaryLength()'
Added a custom definition for 'isEmptyStringTreatedAsNull()'
Added a custom definition for 'supportsTupleDistinctCounts()'
Added a custom definition for 'getDual()'
Added a custom definition for 'getFromDualForSelectOnly()'

In TimesTenSqlAstTranslator.java

Added a custom definition for 'renderRowsToClause()'

In TimesTenLimitHandler.java

    The class now extends 'AbstractLimitHandler'
    Removed a custom definition for 'insert()'
    Added a custom definition for 'supportsLimit()'
    Added a custom definition for 'supportsOffset()'
    Added a custom definition for 'supportsLimitOffset()'
    Added a custom definition for 'supportsVariableLimit()'
    Added a custom definition for 'convertToFirstRowValue(int zeroBasedFirstResult)'
    Added a custom definition for 'useMaxForLimit()'
    Added a custom definition for 'limitClause(boolean hasFirstRow)'

In TimesTenSequenceSupport.java

    The Class now implements 'SequenceSupport'
    Added a custom definition for 'supportsSequences()'
    Added a custom definition for 'supportsPooledSequences()'
    Added a custom definition for 'getSelectSequenceNextValString(String sequenceName)'
    Added a custom definition for 'getSequenceNextValString(String sequenceName)'
    Added a custom definition for 'getCreateSequenceString(String sequenceName)'
    Added a custom definition for 'getDropSequenceString(String sequenceName)'

Testing:

The changes were tested with some local tests we have using this Hibernate 6 TimesTen community dialect.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

hibernate-github-bot · 2025-07-08T21:48:48Z

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
↳ Offending commits: [7477aef, 67cbf58, 6ba01b1, 4502461, 976686f, 8613200, a526f53]

› This message was automatically generated.

carlblan · 2025-07-08T22:14:09Z

@beikov @mbellade @yrodiere

Here's a new PR to update the TimesTen Community Dialect for Hibernate 6.6

I closed the previous PR: #10273
Since I accidentally fetched/updated from main instead of 6.6 branch

This is a clean PR with the same changes but addressed the previous comments:

Removed the copyright headers from my changes since Oracle has been added as a corporate contributor.
Addressed comments for 'initializeFunctionRegistry()'

Let me know any other comment.

Thanks

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

...mmunity-dialects/src/main/java/org/hibernate/community/dialect/TimesTenSqlAstTranslator.java

beikov · 2025-07-14T12:19:33Z

...mmunity-dialects/src/main/java/org/hibernate/community/dialect/TimesTenSqlAstTranslator.java

@@ -143,4 +145,56 @@ protected boolean supportsRowValueConstructorSyntaxInInList() {
 	protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
 		return false;
 	}
+
+	@Override


Since this function is only used in TimesTen, could you please remove it from AbstractSqlAstTranslator?

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

…LimitHandler and TimesTenSequenceSupport

…ate contributor. Also addressing some comments from the PR

beikov · 2025-07-29T07:30:44Z

...mmunity-dialects/src/main/java/org/hibernate/community/dialect/TimesTenSqlAstTranslator.java

+			try {
+				if ( fetchClauseExpression != null ) {
+					// We need to substract 1 row to fit maxRows
+					renderFetchPlusOffsetExpressionAsLiteral( fetchClauseExpression, offsetClauseExpression, -1 );


Does TimesTen not support a parameter here?

Suggested change

renderFetchPlusOffsetExpressionAsLiteral( fetchClauseExpression, offsetClauseExpression, -1 );

renderFetchPlusOffsetExpressionAsSingleParameter( fetchClauseExpression, offsetClauseExpression, -1 );

beikov · 2025-07-29T07:33:21Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"rtrim", new StandardSQLFunction("rtrim", StandardBasicTypes.STRING) 
+		);
+		functionContributions.getFunctionRegistry().register( 
+				"ltrim", new StandardSQLFunction("ltrim", StandardBasicTypes.STRING) 
+		);


Why not use the standard trim function definitions?

Suggested change

functionContributions.getFunctionRegistry().register(

"rtrim", new StandardSQLFunction("rtrim", StandardBasicTypes.STRING)

);

functionContributions.getFunctionRegistry().register(

"ltrim", new StandardSQLFunction("ltrim", StandardBasicTypes.STRING)

);

functionFactory.trim2();

beikov · 2025-07-29T07:34:03Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"length", new StandardSQLFunction("length", StandardBasicTypes.LONG)
+		);


Suggested change

functionContributions.getFunctionRegistry().register(

"length", new StandardSQLFunction("length", StandardBasicTypes.LONG)

);

functionFactory.characterLength_length( SqlAstNodeRenderingMode.DEFAULT );

beikov · 2025-07-29T07:35:36Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"to_char", new StandardSQLFunction("to_char", StandardBasicTypes.STRING)
+		);


Suggested change

functionContributions.getFunctionRegistry().register(

"to_char", new StandardSQLFunction("to_char", StandardBasicTypes.STRING)

);

functionFactory.toCharNumberDateTimestamp();

beikov · 2025-07-29T07:38:19Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"str", new StandardSQLFunction("to_char", StandardBasicTypes.STRING)
+		);


It seems this is already registered by Dialect.initializeFunctionRegistry to use the casting mechanism. It would be best to take a look at OracleDialect#castPattern and copy over what is compatible or makes sense.

Suggested change

functionContributions.getFunctionRegistry().register(

"str", new StandardSQLFunction("to_char", StandardBasicTypes.STRING)

);

beikov · 2025-07-29T07:39:11Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"substring", new StandardSQLFunction( "substr", StandardBasicTypes.STRING )
+		);


Suggested change

functionContributions.getFunctionRegistry().register(

"substring", new StandardSQLFunction( "substr", StandardBasicTypes.STRING )

);

functionFactory.substring_substr();

beikov · 2025-07-29T07:39:37Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"to_date", new StandardSQLFunction("to_date", StandardBasicTypes.TIMESTAMP)
+		);


Already covered by functionFactory.toCharNumberDateTimestamp() above

Suggested change

functionContributions.getFunctionRegistry().register(

"to_date", new StandardSQLFunction("to_date", StandardBasicTypes.TIMESTAMP)

);

beikov · 2025-07-29T07:43:54Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"current_date",      new CurrentFunction("sysdate", "sysdate", dateType) 
+		);
+		functionContributions.getFunctionRegistry().register( 
+				"current_time",      new CurrentFunction("sysdate", "sysdate", timeType) 
+		);
+		functionContributions.getFunctionRegistry().register( 
+				"current_timestamp", new CurrentFunction("sysdate", "sysdate", timestampType) 
+		);


Already covered by Dialect.initializeFunctionRegistry, which uses the currentTime, currentTimestamp and currentDate of this Dialect to determine the SQL fragment.

Suggested change

functionContributions.getFunctionRegistry().register(

"current_date", new CurrentFunction("sysdate", "sysdate", dateType)

);

functionContributions.getFunctionRegistry().register(

"current_time", new CurrentFunction("sysdate", "sysdate", timeType)

);

functionContributions.getFunctionRegistry().register(

"current_timestamp", new CurrentFunction("sysdate", "sysdate", timestampType)

);

beikov · 2025-07-29T07:44:15Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"to_timestamp", new StandardSQLFunction("to_timestamp", StandardBasicTypes.TIMESTAMP)
+		);


Already covered by functionFactory.toCharNumberDateTimestamp() above

Suggested change

functionContributions.getFunctionRegistry().register(

"to_timestamp", new StandardSQLFunction("to_timestamp", StandardBasicTypes.TIMESTAMP)

);

beikov · 2025-07-29T07:44:33Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+	public String currentTime() {
+		return "sysdate";
+	}
+


Suggested change

@Override

public String currentTimestamp() {

return "sysdate";

}

beikov · 2025-07-29T07:45:32Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+				"sysdate", new CurrentFunction("sysdate", "sysdate", timestampType)
+		);
+		functionContributions.getFunctionRegistry().register( 
+				"getdate", new StandardSQLFunction("getdate", StandardBasicTypes.TIMESTAMP)


Suggested change

"getdate", new StandardSQLFunction("getdate", StandardBasicTypes.TIMESTAMP)

"getdate", new CurrentFunction( "getdate", "getdate", timestampType )

beikov · 2025-07-29T07:47:05Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"add_months",     new StandardSQLFunction("add_months", StandardBasicTypes.DATE)
+		);
+		functionContributions.getFunctionRegistry().register( 
+				"months_between", new StandardSQLFunction("months_between", StandardBasicTypes.FLOAT)
+		);


Suggested change

functionContributions.getFunctionRegistry().register(

"add_months", new StandardSQLFunction("add_months", StandardBasicTypes.DATE)

);

functionContributions.getFunctionRegistry().register(

"months_between", new StandardSQLFunction("months_between", StandardBasicTypes.FLOAT)

);

functionFactory.addMonths();

functionFactory.monthsBetween();

beikov · 2025-07-29T07:47:39Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"trunc", new StandardSQLFunction("trunc")
+		);


Suggested change

functionContributions.getFunctionRegistry().register(

"trunc", new StandardSQLFunction("trunc")

);

functionContributions.getFunctionRegistry().register(

"trunc",

new OracleTruncFunction( functionContributions.getTypeConfiguration() )

);

functionContributions.getFunctionRegistry().registerAlternateKey( "truncate", "trunc" );

beikov · 2025-07-29T07:48:21Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"round", new StandardSQLFunction("round")
+		);


Suggested change

functionContributions.getFunctionRegistry().register(

"round", new StandardSQLFunction("round")

);

functionFactory.round();

beikov · 2025-07-29T07:48:39Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"bitnot", new StandardSQLFunction("bitnot", StandardBasicTypes.INTEGER)
+		);


Suggested change

functionContributions.getFunctionRegistry().register(

"bitnot", new StandardSQLFunction("bitnot", StandardBasicTypes.INTEGER)

);

functionFactory.round();

beikov · 2025-07-29T07:53:11Z

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenDialect.java

+		functionContributions.getFunctionRegistry().register( 
+				"nvl", new StandardSQLFunction("nvl")
+		);


Suggested change

functionContributions.getFunctionRegistry().register(

"nvl", new StandardSQLFunction("nvl")

);

functionRegistry.namedDescriptorBuilder( "nvl" )

.setMinArgumentCount( 2 )

.setArgumentTypeResolver( StandardFunctionArgumentTypeResolvers.ARGUMENT_OR_IMPLIED_RESULT_TYPE )

.setReturnTypeResolver( StandardFunctionReturnTypeResolvers.useFirstNonNull() )

.register();

);

beikov

Please try to reuse the existing CommonFunctionFactory methods as much as possible, since they also contain parameter type inference information and other extras that you are missing right now.

carlblan changed the title ~~Oracle TimesTen 6.6 Dialect Updates~~ Oracle TimesTen Dialect for Hibernate 6.6 Updates Jul 8, 2025

beikov requested changes Jul 14, 2025

View reviewed changes

carlblan added 7 commits July 28, 2025 21:53

Adding updates to TimesTenDialect, TimesTenSqlAstTranslator, TimesTen…

7477aef

…LimitHandler and TimesTenSequenceSupport

Fix indentation

67cbf58

Fix typo

6ba01b1

Changes in copyright headers

4502461

Fix indentation

976686f

Removing Copyright headers now that Oracle has been added as a corpor…

8613200

…ate contributor. Also addressing some comments from the PR

Addressing PR comments

a526f53

carlblan force-pushed the timesten_dialect_updates branch from 7a81939 to a526f53 Compare July 28, 2025 21:55

beikov reviewed Jul 29, 2025

View reviewed changes

beikov requested changes Jul 29, 2025

View reviewed changes

	renderFetchPlusOffsetExpressionAsLiteral( fetchClauseExpression, offsetClauseExpression, -1 );
	renderFetchPlusOffsetExpressionAsSingleParameter( fetchClauseExpression, offsetClauseExpression, -1 );

	functionContributions.getFunctionRegistry().register(
	"str", new StandardSQLFunction("to_char", StandardBasicTypes.STRING)
	);

	functionContributions.getFunctionRegistry().register(
	"to_date", new StandardSQLFunction("to_date", StandardBasicTypes.TIMESTAMP)
	);

	functionContributions.getFunctionRegistry().register(
	"to_timestamp", new StandardSQLFunction("to_timestamp", StandardBasicTypes.TIMESTAMP)
	);

	"getdate", new StandardSQLFunction("getdate", StandardBasicTypes.TIMESTAMP)
	"getdate", new CurrentFunction( "getdate", "getdate", timestampType )

-		functionContributions.getFunctionRegistry().register(
-				"nvl", new StandardSQLFunction("nvl")
-		);
+		functionRegistry.namedDescriptorBuilder( "nvl" )
+				.setMinArgumentCount( 2 )
+				.setArgumentTypeResolver( StandardFunctionArgumentTypeResolvers.ARGUMENT_OR_IMPLIED_RESULT_TYPE )
+				.setReturnTypeResolver( StandardFunctionReturnTypeResolvers.useFirstNonNull() )
+				.register();
+		);

Uh oh!

Oracle TimesTen Dialect for Hibernate 6.6 Updates #10492

Are you sure you want to change the base?

Oracle TimesTen Dialect for Hibernate 6.6 Updates #10492

Uh oh!

Conversation

carlblan commented Jul 8, 2025

Uh oh!

hibernate-github-bot bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlblan commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beikov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hibernate-github-bot bot commented Jul 8, 2025 •

edited

Loading