Skip to content

HHH-19540 fix coalesce(:ids, 1) automatic add parentheses #10333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xiaoye-2018
Copy link

@xiaoye-2018 xiaoye-2018 commented Jun 14, 2025

Repairing coalescence (ids, 1) will generate SQL for coalescence ((?,?,?), 1).
Similar situations: order by field(id , :id)

current:
Even though coalescence (: param1,: param2, 1) , only generating coalescence (?,?,?, 1), not add extral parentheses


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19540

@gavinking
Copy link
Member

I doubt it's really correct to assume that an expression which follows a , is a parenthesized expression.

I mean, what about stuff like:

 insert into table (col1, col2) values (1,2), (3,4)

@xiaoye-2018
Copy link
Author

I doubt it's really correct to assume that an expression which follows a , is a parenthesized expression.

I mean, what about stuff like:

 insert into table (col1, col2) values (1,2), (3,4)

performing:
insert table xx (col1, col2) values (?,?)
Can collection be used as a parameter under normal circumstances?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants