Skip to content

fix(registry): make the tabs active label follow the sliding indicator #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajanpanth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(registry): make the tabs active label follow the sliding indicator #3437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 50 additions & 8 deletions registry/components/tabs-slide-indicator/demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,28 @@
background: #18181b;
transform: translateX(var(--hf-tab-x));
box-shadow: 0 12px 26px rgba(0, 0, 0, 0.18);
overflow: hidden;
z-index: 2;
}
.hf-transition-tabs-slide-indicator button {
position: relative;
z-index: 1;
height: 36px;
border: 0;
background: transparent;
color: #71717a;
color: #6b6b73;
font-weight: 600;
}
.hf-transition-tabs-slide-indicator button:nth-of-type(2) {
.hf-transition-tabs-slide-indicator .indicator-labels {
position: absolute;
top: 0;
left: 0;
display: grid;
grid-template-columns: repeat(3, 86px);
transform: translateX(calc(var(--hf-tab-x) * -1));
pointer-events: none;
}
.hf-transition-tabs-slide-indicator .indicator-labels button {
color: #fff;
}
</style>
Expand All @@ -88,7 +99,12 @@
{ "id": "labels", "type": "string", "role": "content", "label": "Labels", "description": "The tab names, separated by commas. Two or more names rebuild the row.", "default": "Plan,Debug,Ask" }
]'
>
<span class="indicator"></span><button>Plan</button><button>Debug</button
<span class="indicator"
><span class="indicator-labels" aria-hidden="true"
><button tabindex="-1">Plan</button><button tabindex="-1">Debug</button
><button tabindex="-1">Ask</button></span
></span
><button>Plan</button><button>Debug</button
><button>Ask</button>
</div>
</div>
Expand Down Expand Up @@ -117,6 +133,17 @@
return Object.prototype.hasOwnProperty.call(table, value) ? value : fallback;
}

// The mirrored copy is decorative: it repeats a label the row
// already carries, so it stays out of the tab order.
function makeTab(text, mirrored) {
var button = document.createElement("button");
button.textContent = text;
if (mirrored) {
button.tabIndex = -1;
}
return button;
}

var accent = accents[pick(accents, vars.accent, "ink")];
var width = widths[pick(widths, vars.width, "standard")];
var radius = shapes[pick(shapes, vars.shape, "pill")];
Expand All @@ -140,14 +167,18 @@
roots[i].style.setProperty("--hf-tab-radius", radius);
// A single tab has nowhere to slide to, so it is left as authored.
if (labels.length > 1) {
// Every label exists twice: once in the row and once in the
// clipped copy the pill carries, so both are rebuilt together.
var mirror = roots[i].querySelector(".indicator-labels");
var old = roots[i].querySelectorAll("button");
for (var j = 0; j < old.length; j += 1) {
old[j].parentNode.removeChild(old[j]);
}
for (var k = 0; k < labels.length; k += 1) {
var button = document.createElement("button");
button.textContent = labels[k];
roots[i].appendChild(button);
roots[i].appendChild(makeTab(labels[k], false));
if (mirror) {
mirror.appendChild(makeTab(labels[k], true));
}
}
roots[i].style.setProperty("--hf-tab-count", String(labels.length));
}
Expand Down Expand Up @@ -190,17 +221,28 @@
background: var(--hf-tab-fill, #18181b);
transform: translateX(calc(var(--hf-tab-x) * var(--hf-tab-step, 1)));
box-shadow: 0 12px 26px rgba(0, 0, 0, 0.18);
overflow: hidden;
z-index: 2;
}
.hf-transition-tabs-slide-indicator button {
position: relative;
z-index: 1;
height: 36px;
border: 0;
background: transparent;
color: #71717a;
color: #6b6b73;
font-weight: 850;
}
.hf-transition-tabs-slide-indicator button:nth-of-type(2) {
.hf-transition-tabs-slide-indicator .indicator-labels {
position: absolute;
top: 0;
left: 0;
display: grid;
grid-template-columns: repeat(var(--hf-tab-count, 3), var(--hf-tab-width, 86px));
transform: translateX(calc(var(--hf-tab-x) * var(--hf-tab-step, 1) * -1));
pointer-events: none;
}
.hf-transition-tabs-slide-indicator .indicator-labels button {
color: #fff;
}
</style>
Expand Down
47 changes: 41 additions & 6 deletions registry/components/tabs-slide-indicator/tabs-slide-indicator.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@
{ "id": "labels", "type": "string", "role": "content", "label": "Labels", "description": "The tab names, separated by commas. Two or more names rebuild the row.", "default": "Plan,Debug,Ask" }
]'
>
<span class="indicator"></span><button>Plan</button><button>Debug</button><button>Ask</button>
<span class="indicator"
><span class="indicator-labels" aria-hidden="true"
><button tabindex="-1">Plan</button><button tabindex="-1">Debug</button
><button tabindex="-1">Ask</button></span
></span
><button>Plan</button><button>Debug</button><button>Ask</button>
</div>

<style>
Expand All @@ -64,17 +69,32 @@
background: var(--hf-tab-fill, #18181b);
transform: translateX(calc(var(--hf-tab-x) * var(--hf-tab-step, 1)));
box-shadow: 0 12px 26px rgba(0, 0, 0, 0.18);
overflow: hidden;
z-index: 2;
}
.hf-transition-tabs-slide-indicator button {
position: relative;
z-index: 1;
height: 36px;
border: 0;
background: transparent;
color: #71717a;
color: #6b6b73;
font-weight: 850;
}
.hf-transition-tabs-slide-indicator button:nth-of-type(2) {
/* The pill carries a clipped copy of the label row. Countering the pill's
own translate keeps that copy aligned with the buttons underneath at
every frame, so the white label is exactly the part of the row the pill
covers - it follows the indicator instead of being pinned to one tab. */
.hf-transition-tabs-slide-indicator .indicator-labels {
position: absolute;
top: 0;
left: 0;
display: grid;
grid-template-columns: repeat(var(--hf-tab-count, 3), var(--hf-tab-width, 86px));
transform: translateX(calc(var(--hf-tab-x) * var(--hf-tab-step, 1) * -1));
pointer-events: none;
}
.hf-transition-tabs-slide-indicator .indicator-labels button {
color: #fff;
}
</style>
Expand Down Expand Up @@ -104,6 +124,17 @@
return Object.prototype.hasOwnProperty.call(table, value) ? value : fallback;
}

// The mirrored copy is decorative: it repeats a label the row already
// carries, so it stays out of the tab order.
function makeTab(text, mirrored) {
var button = document.createElement("button");
button.textContent = text;
if (mirrored) {
button.tabIndex = -1;
}
return button;
}

var accent = accents[pick(accents, vars.accent, "ink")];
var width = widths[pick(widths, vars.width, "standard")];
var radius = shapes[pick(shapes, vars.shape, "pill")];
Expand All @@ -127,14 +158,18 @@
roots[i].style.setProperty("--hf-tab-radius", radius);
// A single tab has nowhere to slide to, so it is left as authored.
if (labels.length > 1) {
// Every label exists twice: once in the row and once in the clipped
// copy the pill carries, so both have to be rebuilt together.
var mirror = roots[i].querySelector(".indicator-labels");
var old = roots[i].querySelectorAll("button");
for (var j = 0; j < old.length; j += 1) {
old[j].parentNode.removeChild(old[j]);
}
for (var k = 0; k < labels.length; k += 1) {
var button = document.createElement("button");
button.textContent = labels[k];
roots[i].appendChild(button);
roots[i].appendChild(makeTab(labels[k], false));
if (mirror) {
mirror.appendChild(makeTab(labels[k], true));
}
}
roots[i].style.setProperty("--hf-tab-count", String(labels.length));
}
Expand Down