Skip to content

fix(lint): quote a combined scale+translate declaration once #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajanpanth wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −1
Open

fix(lint): quote a combined scale+translate declaration once #3435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions packages/lint/src/rules/gsap.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,32 @@ describe("GSAP rules", () => {
expect(finding?.selector).toBe("#hero");
});

it("quotes a combined scale+translate declaration once", async () => {
const html = `
<html><body>
<div id="root" data-composition-id="c1" data-width="1920" data-height="1080">
<div class="scene-1"></div>
</div>
<style>
.scene-1 { transform: scale(1.08) translate3d(1.5%, 0, 0); }
</style>
<script>
window.__timelines = window.__timelines || {};
const tl = gsap.timeline({ paused: true });
tl.to(".scene-1", { duration: 1, x: 100, scale: 1.2 });
window.__timelines["c1"] = tl;
</script>
</body></html>`;
const result = await lintHyperframeHtml(html);
const finding = result.findings.find((f) => f.code === "gsap_css_transform_conflict");
expect(finding).toBeDefined();
// One declaration matches both the translate and the scale selector map,
// so the two lookups return the same text and it must not be repeated.
const transform = "scale(1.08) translate3d(1.5%, 0, 0)";
expect(finding?.message.split(transform)).toHaveLength(2);
expect(finding?.fixHint?.split(transform)).toHaveLength(2);
});

it("does NOT warn when tl.to targets element without CSS transform", async () => {
const html = `
<html><body>
Expand Down
5 changes: 4 additions & 1 deletion packages/lint/src/rules/gsap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1332,7 +1332,10 @@ export const gsapRules: LintRule<LintContext>[] = [
scaleProps.length > 0 ? matchCssTransform(sel, cssScaleSelectors) : undefined;
if (!cssFromTranslate && !cssFromScale) continue;
const existing = conflicts.get(sel) ?? {
cssTransform: [cssFromTranslate, cssFromScale].filter(Boolean).join(" "),
// A single declaration such as `transform: scale(...) translate3d(...)`
// matches both selector maps, so the two lookups return the same text.
// Dedupe before joining, or the message quotes it twice.
cssTransform: [...new Set([cssFromTranslate, cssFromScale].filter(Boolean))].join(" "),
props: new Set<string>(),
raw: call.raw,
};
Expand Down