docs: say one paused ROOT timeline, not "timelines must be paused" - #3428
Open
miguel-heygen wants to merge 1 commit into
Open
docs: say one paused ROOT timeline, not "timelines must be paused"#3428miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
`skills/hyperframes-core/SKILL.md` has always been right: "Each composition
registers exactly one gsap.timeline({ paused: true })... Don't manually nest
sub-timelines into the host."
The four compressed copies dropped both halves and said only "GSAP timelines
must be paused and registered on window.__timelines". Plural, with no cap and
no warning against nesting. An author following that writes a paused timeline
per scene and combines them, which is precisely the shape that renders black:
a paused child never advances when the root is seeked, so every frame is the
t=0 state, and lint, check and validate all pass because none looks at pixels.
This is the drift the skill-catalog rule exists to prevent — a compressed copy
asserting something the skill does not.
The runtime now repairs this shape (#3427), so nobody is stuck. This closes the
door on authoring it in the first place.
Both template files kept byte-identical, as required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The four compressed copies of the timeline contract now say what the skill says: one
paused timeline, the registered root, and don't nest your own paused sub-timelines into it.
Why
skills/hyperframes-core/SKILL.mdhas always been correct:Every compressed copy dropped both halves:
Plural, no cap, no warning against nesting. An author following that writes a paused
timeline per scene and combines them with
.add()— exactly the shape that renders black,because a paused child never advances when the root is seeked. Every frame is the t=0 state,
and
lint,checkandvalidateall pass, none of them looking at pixels.This is the drift the skill-catalog sync rule exists to prevent: a compressed copy asserting
something the skill does not.
How
Four surfaces, all previously carrying the same sentence:
CLAUDE.mdAGENTS.mdpackages/cli/src/templates/_shared/CLAUDE.mdpackages/cli/src/templates/_shared/AGENTS.mdThe two template files are written into every
hyperframes initproject and must staybyte-identical — verified with
diff -qafter the edit.Relationship to #3427
#3427 makes the runtime repair this
shape, so nobody following the old wording is stuck. This PR stops it being authored in the
first place. Either alone is a partial fix: the runtime one leaves the misleading guidance in
place, and this one leaves every existing composition broken.
Not covered
docs/prose is untouched; a grep for the old sentence acrossdocs/,README.mdanddocs/guides/returns nothing, so these four were the whole set.duplicate it for the subset it can see.