fix(cli): give the Windows browser-path hint its PowerShell form too - #3390
Open
vanceingalls wants to merge 1 commit into
Open
fix(cli): give the Windows browser-path hint its PowerShell form too#3390vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
`set VAR=value` is cmd.exe syntax. In PowerShell `set` resolves to the Set-Variable alias, which creates a shell variable rather than an environment one — it never reaches the spawned browser, so a PowerShell user follows the hint exactly and sees the same crash. Both forms are now printed. The hint only renders on win32, so its text was unasserted on Linux CI. Added a case that pins `process.platform` for the call and checks both forms are present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nit raised in the #2481 review, which merged before this landed — so it comes as its own PR.
The hint prints
set HYPERFRAMES_BROWSER_PATH="C:\Program Files\...", which is cmd.exe syntax. In PowerShellsetresolves to theSet-Variablealias: it creates a shell variable, not an environment one, so it never reaches the spawned browser. A PowerShell user follows the hint exactly and sees the sameSTATUS_STACK_BUFFER_OVERRUNcrash. Both forms are now printed.The hint only renders on win32, so its text was unasserted on Linux CI — a case that pins
process.platformfor the call now checks both forms are present.🤖 Generated with Claude Code