feat: add German language support via espeak-ng (lang_code='d'/'de')#346
Open
Haydar061 wants to merge 1 commit into
Open
feat: add German language support via espeak-ng (lang_code='d'/'de')#346Haydar061 wants to merge 1 commit into
Haydar061 wants to merge 1 commit into
Conversation
Add lang_code='d' (alias 'de') for German text-to-speech using the
existing EspeakG2P pipeline with sentence-boundary chunking.
- pipeline.py: add 'de' -> 'd' alias and 'd' -> 'de' LANG_CODE
- __main__.py: expose 'd' in the CLI --language choices
- Remove outdated warning that claimed chunking was not implemented;
the __call__ method already handles non-English chunking
Usage:
pipeline = KPipeline(lang_code='d') # or lang_code='de'
for result in pipeline('Guten Morgen', voice='...'): ...
python3 -m kokoro -l d --voice df_... -o out.wav
Closes hexgrad#290
Author
|
Hey, just wanted to check in on this PR! Happy to make any changes if needed. Have a great day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds German language support using the existing
EspeakG2Ppipeline, consistent with how Spanish, French, Italian, Hindi, and Portuguese are already supported.Changes
kokoro/pipeline.py'de': 'd'alias toALIASES'd': 'de'entry toLANG_CODES(under# espeak-ng)__call__method already handles sentence-boundary chunking for all non-English languageskokoro/__main__.py'd'(German) to the CLI--languagechoicesUsage
python3 -m kokoro -l d --voice df_... -t "Guten Morgen" -o output.wavNotes
espeak-ngG2P, same as all other non-English/non-CJK languages.!?) via the existing chunking logic in__call__espeak-ngto be installed (apt-get install espeak-ng)Closes #290