Loosen misaki[en] pin so pip install kokoro resolves (fixes #321)#339
Open
chiddekel wants to merge 1 commit into
Open
Loosen misaki[en] pin so pip install kokoro resolves (fixes #321)#339chiddekel wants to merge 1 commit into
chiddekel wants to merge 1 commit into
Conversation
kokoro bumps the misaki[en] floor to its own version on every release (>=0.9.4 here). When kokoro is published to PyPI before the matching misaki, a fresh 'pip install kokoro' fails with 'No matching distribution found for misaki>=0.9.x', as reported in hexgrad#321. The misaki API kokoro uses (en.G2P, espeak, ZHG2P(version=, en_callable=)) has been stable since misaki 0.8.0, so the exact-version lockstep is unnecessary. Relaxing the floor to >=0.9.2 keeps phoneme/data parity within the 0.9 minor while letting pip still pick the newest misaki when available, and removes the publish-ordering trap. uv.lock already resolves misaki 0.9.2. Fixes hexgrad#321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pip install kokorocan fail with:kokorobumps themisaki[en]floor to its own version number on every release (currentlymisaki[en]>=0.9.4). Becausekokoroandmisakiare published separately, any window wherekokorolands on PyPI before the matchingmisakimakes the package un-installable from PyPI alone — even into a fresh venv. This is exactly the failure in #321 (it hit0.7.16→misaki 0.7.4; the same trap recurs every release).Fix
Relax the pin from
misaki[en]>=0.9.4tomisaki[en]>=0.9.2— a one-line change.Why this is safe:
en.G2P,espeak.EspeakFallback/EspeakG2P,ja.JAG2P, andzh.ZHG2P(version=..., en_callable=...). That surface was last matched to misaki 0.8.0 (commitefa91a8, "Match misaki==0.8.0 dev branch") and hasn't changed since — so the exact-version lockstep is unnecessary.0.9.4today);0.9.2only acts as a fallback during the publish gap, and stays within the0.9minor for phoneme/data parity.uv.lockalready pinsmisakiat0.9.2withspecifier = ">=0.9.2", so this alignspyproject.tomlwith what the repo already resolves.Reproduction (from the issue)
python3 -m venv /tmp/test /tmp/test/bin/pip install kokoro # failed when misaki lagged kokoroFixes #321