Fix unbound variable error #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` remote: -----> App not compatible with buildpack: https://buildpack-registry.s3.amazonaws.com/buildpacks/heroku/ruby.tgz remote: /tmp/codon/tmp/buildpacks/50d5eddf222a9b7326028041d4e6509f915ccf2c/bin/detect: line 12: BUILD_DIR: unbound variable remote: /tmp/codon/tmp/buildpacks/50d5eddf222a9b7326028041d4e6509f915ccf2c/bin/detect: line 12: output::error: command not found ```
``` ANSI_YELLOW='\033[1;33m' ^---------^ SC2034 (warning): ANSI_YELLOW appears unused. Verify use (or export if used externally). ANSI_BLUE='\033[1;34m' ^-------^ SC2034 (warning): ANSI_BLUE appears unused. Verify use (or export if used externally). ```
```
$ git ls-files -z --cached --others --exclude-standard ':(exclude)*.rb' 'bin/*' '*/bin/*' '*.sh' | \
xargs -0 shellcheck --check-sourced --color=always
In bin/support/bash_functions.sh line 34:
return $ec
^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
return "$ec"
In bin/support/bash_functions.sh line 53:
return $skip_java_install
^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
return "$skip_java_install"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
```
schneems
force-pushed
the
schneems/fix-unbound-variable
branch
from
04afbbd to
8484138
Compare
dzuelke
previously requested changes
Nov 18, 2025
Contributor
dzuelke
left a comment
dzuelke
left a comment
There was a problem hiding this comment.
It's easier/safer to have the escape codes evaluated at time of assignment (using $'...' syntax), and then use a plain echo without -e, or, even simpler and without a while read loop, have sed do the "wrapping"
Co-authored-by: David Zuelke <[email protected]> Signed-off-by: Richard Schneeman <[email protected]>
Co-authored-by: David Zuelke <[email protected]> Signed-off-by: Richard Schneeman <[email protected]>
```
$ git ls-files -z --cached --others --exclude-standard ':(exclude)*.rb' 'bin/*' '*/bin/*' '*.sh' | \
xargs -0 shellcheck --check-sourced --color=always
In bin/support/bash_functions.sh line 19:
local line
^--^ SC2034 (warning): line appears unused. Verify use (or export if used externally).
```
Contributor
Author
|
I merged all your blocking style suggestions and added an output to the sed line. This is now ready for re-review. I'll start working on a PR to https://github.com/heroku/heroku-buildpack-python/blob/b4260ada2ea84dd54b318117ba94183ba5c41e03/lib/output.sh#L70-L87 to apply your style suggestions to the source of that code. |
colincasey
approved these changes
Nov 18, 2025
schneems
dismissed
dzuelke’s stale review
I got approval from Colin on the suggested changes. If there's more, I'll prioritize them. I need to get this fix released to customers.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When:
heroku/rubyas a buildpack (NOT during the auto-buildpack detection)GemfileWhen they should see a detailed error output explaining why they couldn't deploy. This behavior was added in #1647 and this error was reported in #1647 (comment).
GUS-W-20256726