fix: test TAP devices in CI #1798
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
CSUM and GUEST_CSUM have been advertised by us for a long time, but we did not notice any failures since few devices advertise the features; thus the features have not been negotiated before.
Apart from devices like the Bluefield, vhost also supports this feature nowadays, which is why using TAP devices would break in some circumstances.
A proper fix for these features is underway in #1488.