fix(fuse): check for the existence of op_header #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may also make sense to revert most of #1337, and remove the existing checks for the error code in other places as they are redundant. |
cagatay-y
force-pushed
the
fuse-err
branch
2 times, most recently
from
6951e2c to
5fb09bd
Compare
cagatay-y
force-pushed
the
fuse-err
branch
2 times, most recently
from
8c90730 to
82b12ed
Compare
If the request fails, the host does not write an op_header and code that assumes its exitence fails. To prevent this, only assume the existence of the out_header and check its error field before continuing with the rest of the response. Fixes hermit-os#1775.
cagatay-y
force-pushed
the
fuse-err
branch
2 times, most recently
from
1d52a1c to
c9a386b
Compare
As the send_command function is now aware of the possibility of op_header to not exist and returns an Err accordingly, we no longer need to pretend Lookup commands do not result in a response with a sized struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the request fails, the host does not write an op_header and code that assumes its exitence fails. To prevent this, only assume the existence of the out_header and check its error field before continuing with the rest of the response. Fixes #1775.
I am marking the PR as draft as it contains commits from the open PR #1730.