Improvements to OAI buld and platform flexibility #375
Conversation
herlesupreeth
left a comment
herlesupreeth
left a comment
There was a problem hiding this comment.
Hey, thank you very much for the PR. I have suggested some changes let me know what you think
.env
Outdated
|
|
||
| # Openairinterface nodeB Parameters | ||
| # SDR USRP/LIMESDR/BLADERF | ||
| SDRPLATFORM=USRP |
There was a problem hiding this comment.
I am against adding this here you can pass it in the docker-compose file. For example, when you deploy oai_enb.yaml you can embed the variable there
.env
Outdated
| SDRPLATFORM=USRP | ||
|
|
||
| # LTE for eNB or NR for gNB | ||
| RADIO=LTE |
There was a problem hiding this comment.
I am against adding this here you can pass it in the docker-compose file. For example, when you deploy oai_enb.yaml you can embed the variable RADIO=LTE and when you use the file oai_gnb.yaml you can use RADIO=NR or something like that
|
|
||
| ARG SDRPLATFORM | ||
|
|
||
| RUN . ./oaienv && cd cmake_targets && \ |
There was a problem hiding this comment.
I would suggest having this logic of selecting the SDRPLATFORM and RADIO in oai_init.sh
There was a problem hiding this comment.
the SDRPLATFORM is part of the build process as OAI compilations requires the platform to be build for.
oaignb.yaml
Outdated
| context: oai | ||
| dockerfile: gnb_dockerfile | ||
| image: docker_oai_gnb | ||
| dockerfile: all_dockerfile |
There was a problem hiding this comment.
rather than building it here. I would suggest to build the image beforehand and use the image name here so that whenever you try between oaienb.yaml and oaignb.yaml the image doesnt get rebuilt
2 participants
Makes running OAI easier by: