Use porting::optional in olp-cpp-sdk-read instead of boost::optional. #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1627 +/- ##
==========================================
+ Coverage 80.27% 80.32% +0.04%
==========================================
Files 349 349
Lines 13945 13951 +6
Branches 1492 1491 -1
==========================================
+ Hits 11194 11205 +11
+ Misses 2150 2147 -3
+ Partials 601 599 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
from
ad19ece to
8a9bb0b
Compare
andrey-kashcheev
previously approved these changes
Aug 8, 2025
olp-cpp-sdk-dataservice-read/tests/PartitionsRepositoryTest.cpp
Outdated
Show resolved
Hide resolved
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
from
8a9bb0b to
cbd4d4a
Compare
mykolamalik
reviewed
Aug 8, 2025
olp-cpp-sdk-dataservice-read/src/repositories/PartitionsCacheRepository.h
Outdated
Show resolved
Hide resolved
Currently, SDK requires C++11 minimum. So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a third part of the task: olp-cpp-sdk-read. Also, initial name "optional.hpp" is changed to optional.h to avoid clang-format header sorting issue. Relates-To: NLAM-23 Signed-off-by: sopov <[email protected]>
asopov-here
force-pushed
the
NLAM-23-std-optional
branch
from
0b71fee to
9ce5a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SDK requires C++11 minimum.
So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. The task NLAM-23 is about making this type configurable. This commit is a third part of the task: olp-cpp-sdk-read.
Relates-To: NLAM-23