-
Notifications
You must be signed in to change notification settings - Fork 407
fix: ensure proper prefix for tenant repositories in storage operations #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: ensure proper prefix for tenant repositories in storage operations #1082
Conversation
|
@nerdeveloper Thank you for following this issue , I looked it before and totally forget this after a period XD . The implementation is LGTM , but I am a little confusing about the testing code , in my opinion , we do not need to mock the backend storage , we use the local storage as the backend provider by default , and the tests maybe should include the behavior changes about multi-tenant's depth server , or do I miss the some original information ? |
|
I am using the local‐filesystem backend (not a mock) inside the tests and added the behaviour change you mentioned (prefix isolation for multi-tenant depth). @scbizu, let me know |
|
Hi @nerdeveloper , I am looking back this issue , and find that the unit testing code maybe unnecessary for this case , because our test code using local as backend provider . And the local storage impl is correct for this case . To keep the behavior is the similar from every backend provider , I prefer to change the storage package and not the CM end , what do you think ? |
See: - helm/chartmuseum#1082 - helm/chartmuseum#794 Signed-off-by: scnace <[email protected]>
|
I have created a PR in storage , @nerdeveloper can you help to check it ? |
See: - helm/chartmuseum#1082 - helm/chartmuseum#794 Signed-off-by: scnace <[email protected]>
See: - helm/chartmuseum#1082 - helm/chartmuseum#794 Signed-off-by: scnace <[email protected]>
See: - helm/chartmuseum#1082 - helm/chartmuseum#794 Signed-off-by: scnace <[email protected]>
This PR fixes a critical tenant isolation bug in ChartMuseum:
Before the fix:
After the fix:
To make it super clear: