Session Attaching #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he session may not have been attached yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever an event is tracked for a profile, we attempt to attach the hello session to the profile via
PATH v1/sessions/:id. While this works in the cases the client was a guest who performed an action tracked back to Hellotext, this does not work in the cases where the the client registers first (which would create the profile on Hellotext), and then performs actions.Because the session assignment only happens when the Hellotext profile has not yet been created. It will not successfully attach sessions to clients who registered prior to performing events.
This PR adjusts the
create_profilefunction to always PATCH to the respective endpoint whenever an event occurs as well. This way, we can attach sessions that have not yet been created for registered users.