separate the saving of sleep score from the computation of sleep score [WIP]#1801
Open
benejoseph wants to merge 1 commit intomasterfrom
Open
separate the saving of sleep score from the computation of sleep score [WIP]#1801benejoseph wants to merge 1 commit intomasterfrom
benejoseph wants to merge 1 commit intomasterfrom
Conversation
Contributor
benejoseph
commented
Oct 14, 2016
benejoseph
commented
- problem was that sleep score was being saved even though a timeline was discarded
- the fix is to save the sleep score as the very last thing of retrievetimelinefast
- also, post-timeline checks shouldn't be in populateTimelines
…s at the end of retrieveTimelineFast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.