Draft
Conversation
Collaborator
|
Hi @bobidle Thanks for working on the music. It's been a while since you've worked on this pull request. I see it is still in draft, are you still working on it? If it is ready, please mark it as ready for review, then we will look at it! The same holds for '💻 Add music note H as an alias of music note B #6226 |
Contributor
Author
|
Thank you @AnneliesVlaar, at the moment the code does not work for all languages, but it should add a demonstration how it could work. I still want to work on and finish it. Also i want to make the notes available as |
Collaborator
|
That's very interesting @bobidle, thank you for diving into it! We're looking forward to the result and will wait for when it's ready to review. |
9a855d3 to
24a4470
Compare
674bb9f to
207fc8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4961 #6225
How to test
Follow these steps to verify this PR works as intended:
Checklist
Done? Check if you have it all in place using this list: (mark with x if done)