Move this.alarm=false to DailyLearningEvent base class; add DirshuAmudYomi exports#11
Merged
Merged
Conversation
…dYomi exports Set this.alarm = false in DailyLearningEvent constructor so all subclasses inherit it automatically, removing the redundant assignments from 10 subclasses. Add DirshuAmudYomi, calculateDirshuAmud, dirshuAmudYomiStart, and DirshuAmudYomiEvent exports to index.ts following the same pattern as other learning calendars. https://claude.ai/code/session_014XDkQY4PVMf39HVTqw5fRS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set this.alarm = false in DailyLearningEvent constructor so all subclasses
inherit it automatically, removing the redundant assignments from 10 subclasses.
Add DirshuAmudYomi, calculateDirshuAmud, dirshuAmudYomiStart, and
DirshuAmudYomiEvent exports to index.ts following the same pattern as other
learning calendars.
https://claude.ai/code/session_014XDkQY4PVMf39HVTqw5fRS