Remove unused view loading and bump deps#306
Conversation
Pin laracord/framework to e7b64d6, bump nightwatch to 1.28, debugbar to 4.3, boost to 2.4.9, sail to 1.62.
📝 WalkthroughWalkthroughThis PR modifies two module service providers to load package migrations instead of views during boot. EventsServiceProvider and IdentityServiceProvider now call Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
composer.json (1)
36-36: ⚡ Quick winConfirm VCS commit pin is valid (laracord/framework)
composer.jsonpinslaracord/frameworktodev-next#e7b64d6; the commit resolves toe7b64d62a09b7c197bcccf6e159b6fcb142ced29(“chore: pin tinker-zero and fix composer formatting (#2)”), so the hash is present. Pinning to a commit still prevents automatic updates (including security fixes), so ensure this tradeoff is intentional and that you have a plan to update when needed.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@composer.json` at line 36, composer.json pins the dependency "laracord/framework" to a specific commit (dev-next#e7b64d6) which prevents automatic updates; verify that the commit hash resolves correctly (it does) and then either replace the commit pin with a maintained version constraint or add a short project-maintenance plan: (a) change "laracord/framework" to a semver tag or branch (e.g., a release like "1.x" or "dev-next" without the commit) if you want automatic updates, or (b) keep the commit pin but document in your project README or dependency policy when and how you'll re-pin/update (including security patch cadence) so the tradeoff is intentional; refer to the dependency key "laracord/framework" in composer.json and update accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@composer.json`:
- Line 36: composer.json pins the dependency "laracord/framework" to a specific
commit (dev-next#e7b64d6) which prevents automatic updates; verify that the
commit hash resolves correctly (it does) and then either replace the commit pin
with a maintained version constraint or add a short project-maintenance plan:
(a) change "laracord/framework" to a semver tag or branch (e.g., a release like
"1.x" or "dev-next" without the commit) if you want automatic updates, or (b)
keep the commit pin but document in your project README or dependency policy
when and how you'll re-pin/update (including security patch cadence) so the
tradeoff is intentional; refer to the dependency key "laracord/framework" in
composer.json and update accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro
Run ID: fb865e5b-4696-475a-b3d4-c5e4b7eb550b
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
app-modules/events/src/EventsServiceProvider.phpapp-modules/identity/src/IdentityServiceProvider.phpcomposer.json
💤 Files with no reviewable changes (2)
- app-modules/events/src/EventsServiceProvider.php
- app-modules/identity/src/IdentityServiceProvider.php
Summary
loadViewsFromcalls from Events and Identity service providers (no views exist in those modules)Test plan
composer installfrom clean state