Skip to content

Remove unused view loading and bump deps#306

Merged
danielhe4rt merged 2 commits into
4.xfrom
chore/remove-unused-views-and-deps-update
Jun 4, 2026
Merged

Remove unused view loading and bump deps#306
danielhe4rt merged 2 commits into
4.xfrom
chore/remove-unused-views-and-deps-update

Conversation

@gvieira18
Copy link
Copy Markdown
Member

@gvieira18 gvieira18 commented Jun 4, 2026

Summary

  • Remove unused loadViewsFrom calls from Events and Identity service providers (no views exist in those modules)
  • Bump dependencies: laracord/framework pinned to e7b64d6, nightwatch 1.28, debugbar 4.3, boost 2.4.9, sail 1.62

Test plan

  • Verify Events module still boots correctly
  • Verify Identity module still boots correctly
  • Run composer install from clean state

image

gvieira18 added 2 commits June 4, 2026 11:11
Pin laracord/framework to e7b64d6, bump nightwatch
to 1.28, debugbar to 4.3, boost to 2.4.9, sail to
1.62.
@gvieira18 gvieira18 requested a review from a team June 4, 2026 14:12
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR modifies two module service providers to load package migrations instead of views during boot. EventsServiceProvider and IdentityServiceProvider now call loadMigrationsFrom() to register migrations from their database/migrations directories, replacing the previous view registration. Additionally, composer.json dependency versions are updated: laracord/framework is pinned to a specific commit, laravel/nightwatch is bumped to ^1.28.0, and several require-dev packages are updated (fruitcake/laravel-debugbar to ^4.3.0, laravel/boost to ^2.4.9, laravel/sail to ^1.62.0).

Possibly related PRs

Suggested reviewers

  • danielhe4rt
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes both main changes: removing unused view loading from service providers and updating dependency versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
composer.json (1)

36-36: ⚡ Quick win

Confirm VCS commit pin is valid (laracord/framework)

composer.json pins laracord/framework to dev-next#e7b64d6; the commit resolves to e7b64d62a09b7c197bcccf6e159b6fcb142ced29 (“chore: pin tinker-zero and fix composer formatting (#2)”), so the hash is present. Pinning to a commit still prevents automatic updates (including security fixes), so ensure this tradeoff is intentional and that you have a plan to update when needed.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@composer.json` at line 36, composer.json pins the dependency
"laracord/framework" to a specific commit (dev-next#e7b64d6) which prevents
automatic updates; verify that the commit hash resolves correctly (it does) and
then either replace the commit pin with a maintained version constraint or add a
short project-maintenance plan: (a) change "laracord/framework" to a semver tag
or branch (e.g., a release like "1.x" or "dev-next" without the commit) if you
want automatic updates, or (b) keep the commit pin but document in your project
README or dependency policy when and how you'll re-pin/update (including
security patch cadence) so the tradeoff is intentional; refer to the dependency
key "laracord/framework" in composer.json and update accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@composer.json`:
- Line 36: composer.json pins the dependency "laracord/framework" to a specific
commit (dev-next#e7b64d6) which prevents automatic updates; verify that the
commit hash resolves correctly (it does) and then either replace the commit pin
with a maintained version constraint or add a short project-maintenance plan:
(a) change "laracord/framework" to a semver tag or branch (e.g., a release like
"1.x" or "dev-next" without the commit) if you want automatic updates, or (b)
keep the commit pin but document in your project README or dependency policy
when and how you'll re-pin/update (including security patch cadence) so the
tradeoff is intentional; refer to the dependency key "laracord/framework" in
composer.json and update accordingly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: fb865e5b-4696-475a-b3d4-c5e4b7eb550b

📥 Commits

Reviewing files that changed from the base of the PR and between 01f60a2 and 1b8b8fd.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • app-modules/events/src/EventsServiceProvider.php
  • app-modules/identity/src/IdentityServiceProvider.php
  • composer.json
💤 Files with no reviewable changes (2)
  • app-modules/events/src/EventsServiceProvider.php
  • app-modules/identity/src/IdentityServiceProvider.php

@gvieira18 gvieira18 linked an issue Jun 4, 2026 that may be closed by this pull request
@gvieira18 gvieira18 self-assigned this Jun 4, 2026
@gvieira18 gvieira18 added refactor Code refactoring dependencies Pull requests that update a dependency file labels Jun 4, 2026
Copy link
Copy Markdown
Contributor

@thalesmengue thalesmengue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@danielhe4rt danielhe4rt merged commit 6a5c9a2 into 4.x Jun 4, 2026
6 checks passed
@danielhe4rt danielhe4rt deleted the chore/remove-unused-views-and-deps-update branch June 4, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: php artisan optimize breaking the laravel container

5 participants