Skip to content

Refactor workflow scheduling: separate update and publish workflows #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2025
Merged

Refactor workflow scheduling: separate update and publish workflows #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca25d05
Initial plan
Copilot Nov 6, 2025
9d7f794
Rename update-packages.yml to update.yml and modify workflows
Copilot Nov 6, 2025
89ef65f
Update .github/workflows/publish.yml
hckhanh Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Publish

on:
workflow_dispatch:
push:
branches:
- main
schedule:
# Run weekly on Monday at 01:00 UTC (1 hour after update.yml)
- cron: '0 1 * * 1'
Comment on lines +5 to +7
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states this runs '1 hour after update.yml', but this assumes update.yml always completes within 1 hour. If the update workflow takes longer than 1 hour or fails, the publish workflow will run on stale code. Consider using workflow_run trigger with 'workflows: [Update]' and 'types: [completed]' to ensure publish only runs after update successfully completes, or add explicit dependency checking.

Copilot uses AI. Check for mistakes.

permissions:
contents: read
Expand Down
21 changes: 0 additions & 21 deletions .github/workflows/update-packages.yml → .github/workflows/update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,24 +60,3 @@ jobs:
fi
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Create Release Pull Request
if: steps.check.outputs.has_updates == 'true'
uses: changesets/action@e0145edc7d9d8679003495b11f87bd8ef63c0cba # v1.5.3
id: changesets
with:
commit: 'chore(release): match upstream terraform providers'
title: 'Update packages to match upstream terraform providers'
publish: pnpm release
commitMode: 'git-cli'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NX_KEY: ${{ secrets.NX_KEY }}
AWS_ENDPOINT_URL: ${{ secrets.AWS_ENDPOINT_URL }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
- name: Auto-merge release PR
if: steps.changesets.outputs.pullRequestNumber != ''
run: |
gh pr merge ${{ steps.changesets.outputs.pullRequestNumber }} --rebase --delete-branch
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}