feat(helm): optional HulyPulse service for presence and push - #325
Open
developerinlondon wants to merge 1 commit into
Open
feat(helm): optional HulyPulse service for presence and push#325developerinlondon wants to merge 1 commit into
developerinlondon wants to merge 1 commit into
Conversation
Adds a hulypulse Deployment and Service behind hulypulse.enabled,
mirroring the commented compose.yml service: in-memory backend by
default with a redis variant, HULY_TOKEN_SECRET drawn from the chart
secret's SERVER_SECRET.
Wires PULSE_URL through the shared ConfigMap the way other endpoints
are: the front receives the public {proto}://{domain}/_pulse URL and
the transactor the in-cluster http://hulypulse:8099, and the ingress
gains a websocket-enabled /_pulse backend when enabled.
Rendered and yaml-validated disabled (no objects, no keys), enabled
with memory backend, enabled with redis, and enabled with ingress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compose stack gained an optional HulyPulse service (README §HulyPulse), but the Helm chart has no way to run it or to hand
PULSE_URLto the front and transactor. This adds it following the chart's existing conventions.What
templates/hulypulse/{deployment,service}.yamlbehindhulypulse.enabled(default false — nothing changes for existing users), mirroring the compose service:HULY_BIND_PORT=8099,HULY_TOKEN_SECRETfrom the chart secret'sSERVER_SECRET,HULY_BACKEND=memoryby default with a redis variant (backend: redis,redisUrls).PULSE_URL(public{proto}://{domain}/_pulse) andPULSE_URL_INTERNAL(http://hulypulse:8099), matching the existing*_INTERNALsplit./_pulsebackend via the existing$backendslist.hulypulse.versiondefaults to0.1.29and is deliberately independent ofhulyVersion, matchingHULY_PULSE_VERSIONin compose.Verified
HULY_REDIS_MODE/HULY_REDIS_URLSrendered/_pulsews backend,PULSE_URL: https://…/_pulseRelated to the chart-conventions work in #323/#324.