fix(helm): pass GitHub App env vars to front for OAuth and installation flows - #286
Merged
ArtyomSavchenko merged 1 commit intoMar 22, 2026
Merged
Conversation
…on flows The front service needs two additional env vars when GitHub integration is enabled: - GITHUB_CLIENTID: used to build the OAuth authorize URL. Without it, the redirect has client_id= (empty) and GitHub returns 404. - GITHUB_APP: the app slug, used to build the installation URL. Without it, the URL becomes /apps//installations/new which returns 404. Also adds githubIntegration.appSlug to values.yaml for the app slug. Signed-off-by: Daniel Kendall <dkendall@ledoweb.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Don Kendall <kendall@donkendall.com>
|
Connected to Huly®: SELFH-285 |
ArtyomSavchenko
approved these changes
Mar 22, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #280. The GitHub integration (
githubIntegration.enabled=true) is broken without two env vars on the front service:GITHUB_CLIENTID— the front builds the OAuth authorize URL client-side. Without it,client_id=is empty → GitHub returns 404.GITHUB_APP— the front builds the GitHub App installation URL. Without it, the URL becomes/apps//installations/new→ 404.Changes
templates/front/deployment.yaml: addGITHUB_CLIENTID(from secret) andGITHUB_APP(from values) whengithubIntegration.enabledvalues.yaml: addappSlugfield togithubIntegrationTest plan
githubIntegrationwith valid GitHub App credentialsclient_id=<value>github.com/apps/<slug>/installations/new🤖 Generated with Claude Code