Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Hazelcast.Net.Tests/Clustering/MembersLifecycleTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,17 @@ await AssertEx.SucceedsEventually(() =>
while (RcMembers.Count > 1)
{
var (memberId, member) = RcMembers.First();
var expectedCount = RcMembers.Count - 1;
HConsole.WriteLine(this, $"Remove member {member.Uuid.Substring(0, 7)} at {member.Host}:{member.Port}...");
stopwatch.Restart();
await RemoveMember(memberId);
HConsole.WriteLine(this, $"Removed member {member.Uuid.Substring(0, 7)} ({(int)stopwatch.Elapsed.TotalSeconds}s)");

await Task.Delay(1000);
// wait for MembersUpdated event to reflect the removal before proceeding
await AssertEx.SucceedsEventually(() =>
{
Assert.That(Volatile.Read(ref membersCount), Is.EqualTo(expectedCount));
}, 20000, 200);

await UseClientOnce(map);
}
Expand Down
2 changes: 2 additions & 0 deletions src/Hazelcast.Net/Clustering/ClusterEvents.cs
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,7 @@ private void CollectSubscription(ClusterSubscription subscription)
{
lock (_collectMutex)
{
if (_disposed == 1) return;
foreach (var memberSubscription in subscription)
_collectSubscriptions.Add(memberSubscription);
_collectTask ??= CollectSubscriptionsAsync(_cancel.Token);
Expand All @@ -757,6 +758,7 @@ private void CollectSubscription(MemberSubscription subscription)
{
lock (_collectMutex)
{
if (_disposed == 1) return;
_collectSubscriptions.Add(subscription);
_collectTask ??= CollectSubscriptionsAsync(_cancel.Token);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Hazelcast.Net/Clustering/MemberConnection.cs
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ private async ValueTask OnSocketShutdown(SocketConnectionBase connection)
#pragma warning restore CA1801
#pragma warning restore IDE0079
{
await DisposeAsync().CfAwait();
await DisposeAsync().CfAwaitNoThrow();
}

/// <summary>
Expand Down
Loading