Open
Conversation
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
OzanCansel
suggested changes
May 2, 2023
Contributor
There was a problem hiding this comment.
@cngzhnp Could you remove changes at RemoteController.cpp and remote_controller_types.cpp since they are generated code, so we don't modify those classes.
Contributor
|
verify |
Contributor
|
Linux test FAILed. |
cngzhnp
force-pushed
the
fix/make_iterators_const_if_possible
branch
from
5338000 to
5b4979f
Compare
Contributor
Author
|
@OzanCansel Thanks for the review, I just reverted back changes on generated source files. |
ihsandemir
requested changes
Oct 10, 2025
| { | ||
| std::sort(entries.begin(), | ||
| entries.end(), | ||
| std::sort(entries.cbegin(), |
Collaborator
There was a problem hiding this comment.
sorting requires non-const iterator, right?
Contributor
Author
There was a problem hiding this comment.
Yes, my mistake sorry for inconvenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR closed by Hazelcast automation as no activity (>3 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions