Skip to content

Add tests to test size of the image to catch regressions#40

Merged
JackPGreen merged 4 commits into
masterfrom
test-image-size
Dec 15, 2025
Merged

Add tests to test size of the image to catch regressions#40
JackPGreen merged 4 commits into
masterfrom
test-image-size

Conversation

@JackPGreen

@JackPGreen JackPGreen commented Dec 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add a test to catch a scenario like introduced in hazelcast/hazelcast-docker#1137, using https://github.com/wagoodman/dive

@JackPGreen JackPGreen changed the title Test image size Add tests to test size of the image to catch regressions Dec 10, 2025
JackPGreen added a commit to hazelcast/hazelcast-docker that referenced this pull request Dec 10, 2025
@JackPGreen
Add tests to test size of the image to catch regressions
f12f1c6 
See hazelcast/docker-actions#40
@JackPGreen JackPGreen force-pushed the test-image-size branch 2 times, most recently from 66af5f8 to ef155fb Compare December 10, 2025 10:52
@JackPGreen JackPGreen mentioned this pull request Dec 10, 2025
Merged
@JackPGreen JackPGreen marked this pull request as ready for review December 10, 2025 11:41
nishaatr
nishaatr requested changes Dec 11, 2025
View reviewed changes
Comment thread .github/workflows/test-test-image-size.yml Outdated
Comment thread assert-image-size/action.yml
JackPGreen added a commit to hazelcast/hazelcast-docker that referenced this pull request Dec 11, 2025
@JackPGreen
https://github.com/hazelcast/docker-actions/pull/40#discussion_r26100…
1032dad 
…44991
@JackPGreen JackPGreen requested a review from nishaatr December 11, 2025 13:08
@sonarqubecloud

sonarqubecloud Bot commented Dec 11, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JackPGreen JackPGreen merged commit fc8d7f0 into master Dec 15, 2025
19 checks passed
@JackPGreen JackPGreen deleted the test-image-size branch December 15, 2025 22:07
JackPGreen added a commit to hazelcast/hazelcast-docker that referenced this pull request Dec 15, 2025
@JackPGreen
Add tests to test size of the image to catch regressions (#1186)
6d5c569 
See hazelcast/docker-actions#40

[Example
execution](https://github.com/hazelcast/hazelcast-docker/actions/runs/20096208572/job/57658190605#step:15:1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldziedziul ldziedziul ldziedziul approved these changes
@nishaatr nishaatr nishaatr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JackPGreen @ldziedziul @nishaatr