Seedwords as QRCode #1465
Open
Seedwords as QRCode #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses net.glxn.qrgen.QRCode to show seedwords as a QRCode for external wallet backup
|
MITM risk vector IMO over only small convenience. |
Summaries: - Restored lost code parts. - Added UI updates - Using char for memory safe seed usage
Contributor
Author
|
@KewbitXMR MITM risk means you're looking your seedwords while having somebody close to you. |
Removing unused import
Using cakewallet's QR Code format
```String formattedSeed = "monero-wallet:?seed=" + seedWords.replace(" ", "+");```
Contributor
|
Showing seed words as a QR code has additional risk, as the QR code can be read by cameras more easily, so I think this PR is invalid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses net.glxn.qrgen.QRCode to show seedwords as a QRCode for external wallet backup
