Exclude superclass-generated names in class placeholders#4902
Merged
crtschin merged 2 commits intohaskell:masterfrom Apr 19, 2026
Merged
Exclude superclass-generated names in class placeholders#4902crtschin merged 2 commits intohaskell:masterfrom
crtschin merged 2 commits intohaskell:masterfrom
Conversation
crtschin
force-pushed
the
crtschin/fix-superclasses-missing-methods
branch
2 times, most recently
from
c78756d to
87fb9eb
Compare
fendor
approved these changes
Apr 19, 2026
Collaborator
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
LGTM, thank you! Just one comment
Superclasses generate bindings in typeclasses as well. When determining which bindings to create placeholders for, these superclass-generated names need to be excluded. At the time of writing, this corresponds to the `mkSuperDictAuxOcc` function in Occurrence.hs in GHC, see the subsection on `Making system names` for the relevant bit.
crtschin
force-pushed
the
crtschin/fix-superclasses-missing-methods
branch
from
8ba1b61 to
77c63d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4450.
Superclasses generate bindings in typeclasses as well. When determining which bindings to create placeholders for, these superclass-generated names need to be excluded. At the time of writing, this corresponds to the
mkSuperDictAuxOccfunction in Occurrence.hs in GHC, see the subsection onMaking system namesfor the relevant bit.