Skip to content

Only check for garbage in key garbage collection test#4900

Merged
crtschin merged 1 commit intohaskell:masterfrom
crtschin:crtschin/improve-dirty-key-gc-test
Apr 18, 2026
Merged

Only check for garbage in key garbage collection test#4900
crtschin merged 1 commit intohaskell:masterfrom
crtschin:crtschin/improve-dirty-key-gc-test

Conversation

@crtschin
Copy link
Copy Markdown
Collaborator

Fixes the flaky error related to gc'ing keys from the state. The test leaves a gap open for a concurrent action to add unrelated keys to the state. Modifies the assertions so they only check the absence of garbage, instead of comparing on unrelated keys.

Tested by repeatedly running the specific test and I couldn't reproduce the flaky error anymore.

ghcide
  garbage collection
    dirty keys
      are deleted from the state: FAIL (0.15s)

Copy link
Copy Markdown
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get this in!

So exciting, it feels like we are almost at a stable test suite.

It's been a years-long endeavour :)

@crtschin crtschin marked this pull request as ready for review April 18, 2026 19:39
@crtschin crtschin merged commit 32a7d2f into haskell:master Apr 18, 2026
57 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants