Only check for garbage in key garbage collection test#4900
Merged
crtschin merged 1 commit intohaskell:masterfrom Apr 18, 2026
Merged
Only check for garbage in key garbage collection test#4900crtschin merged 1 commit intohaskell:masterfrom
crtschin merged 1 commit intohaskell:masterfrom
Conversation
fendor
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky error related to gc'ing keys from the state. The test leaves a gap open for a concurrent action to add unrelated keys to the state. Modifies the assertions so they only check the absence of garbage, instead of comparing on unrelated keys.
Tested by repeatedly running the specific test and I couldn't reproduce the flaky error anymore.