Only show linear arrows on data constructors with LinearTypes#4862
Merged
fendor merged 4 commits intohaskell:masterfrom Apr 1, 2026
Merged
Only show linear arrows on data constructors with LinearTypes#4862fendor merged 4 commits intohaskell:masterfrom
fendor merged 4 commits intohaskell:masterfrom
Conversation
Collaborator
|
Thanks for this fantastic work! ❤️❤️❤️ Unfortunately I can't make the review because I have totally lost the details after 4 years. I didn't get in touch with Haskell for a long time and not familiar with recent ghc versions. |
crtschin
force-pushed
the
crtschin/datacon-linear-hover
branch
from
850ff2a to
e64e4b1
Compare
fendor
reviewed
Mar 25, 2026
fendor
approved these changes
Mar 28, 2026
Collaborator
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution! I have a couple of comments, but otherwise we can merge this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2904.
Does what it says on the tin. Mostly follows the investigation @July541 already did here. Some notes:
HscEnv, and I didn't know how to do so otherwise.DataConinto aTypeused to occur throughdataConWrapId, which I changed todataConDisplayType, which also displays wrapper types from what I can tell.ghcide/src/Development/IDE/Plugin/Completions.hs, because I changed the signature ofsafeTyThingType. I didn't understand what was being completed so I stuck to always emitting linear annotations there.