Added 2 docs for SSH and Transit Secret engine with HSM #1375
+492
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
Adit Shah seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
Contributor
Vercel Previews Deployed
|
Contributor
Broken Link CheckerNo broken links found! 🎉 |
Contributor
Author
|
We can decline this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please go to the
Previewtab and select the appropriate template:I propose following changes in the existing doc.
Managed Keys module work with Transit, SSH and PKI Secret engine as of today.
Managed keys can be configured with AWS KMS, GCP Cloud KMS, Azure Key vault and pkcs11 based HSMs.
IBM HSM uses opencryptoki (which is enterprise implementation of pkcs11) and EP11 Token.
Hence I have created 2 generalised docs which contains info on how to configure SSH Secret engine and Transit Secret engine with Managed Keys module with pkcs11 based HSMs.
As EP11 is also similar to pkcs11, I have added a note in the doc about it, with reference IBM documentation.
To categorise better, I created a tree structure. (Review this)
I need review for the following :
Note : I need these both SSH and Transit docs to be there in 1.20.x as well.
And I need Transit Secret Engine Doc to be 1.19.x version as well.