feat: add warning about deadlock potential with MSSQL and Vault #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MSSQL, modifying a role acquires a lock that prevents even read operations, which can lead to temporary deadlocks. It is very easy for users to be blindsided by these deadlocks, since with dynamic credential creation such a modification can occur at any time. Unless a user is a database expert, they will not be aware of this issue. See also https://ci.xovis.com/job/Cirrus/job/Suite-pr-cleanup/.
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Contributor
Vercel Previews Deployed
|
Contributor
Broken Link CheckerNo broken links found! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MSSQL, modifying a role acquires a lock that prevents even read operations, which can lead to temporary deadlocks. It is very easy for users to be blindsided by these deadlocks, since with dynamic credential creation in Vault such a modification can occur at any time. Unless a user is a database expert, they will not be aware of this issue.
See also https://ci.xovis.com/job/Cirrus/job/Suite-pr-cleanup/.