Replaced BasePath usage in universe tests, acm, ad, alloydb, and apigee#27207
Merged
modular-magician merged 1 commit intohashicorp:mainfrom May 1, 2026
Conversation
…ee (hashicorp#17370) [upstream:3e261ae3d5b07039626fe38af5a7b0dc068a255d] Signed-off-by: Modular Magician <magic-modules@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial set of replacements of BasePath usage in handwritten files with the transport_tpg.BaseUrl function.
Note: String concatenation is used instead of URL joining because URL joining would escape
{}characters, preventing ReplaceVars from working properly.Options considered:
confighas to be passed twice.productto ReplaceVars and implicitly add the base URL to the beginning of the URL{{ProductNameBasePath}}variables, trim the BasePath suffix, look up the relevant product in the registry (with the lowercaseproductname), and compute its BaseUrl using the config that was also passed in.services, most of which are via ReplaceVars.)config.*BasePathfields: Handle *BasePath replacement with BaseUrl func GoogleCloudPlatform/magic-modules#17385Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#17370