fix: added EmptyOrUnsetBlockDiffSuppress to the scalingMode field in resource google_cloud_run_v2_service
#25569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n resource `google_cloud_run_v2_service` (hashicorp#15904) [upstream:05d749828aebd97521e0560ad3382bdd673ddacf] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
a team,
NickElliot,
ScottSuarez,
SirGitsalot,
c2thorn,
hao-nan-li,
melinath,
rileykarson,
roaks3,
shuyama1,
slevenick,
trodge and
zli82016
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25457
According to the REST API, if not specified, it defaults to "AUTOMATIC".
While GoogleCloudPlatform/magic-modules#15808 fixes the case where the entire
scalingblock is missing and causing permadiff, it doesn't handle a case where the block only contains "min_instance_count = 0".What happens is, if
min_instance_count = 0is the only field specified, the response from the API has thescaling = []and so it's saved as in the terraform state file.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#15904