Skip to content

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Sep 17, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Relates OR Closes #0000

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Add List feature to resources that support plural data sources

% make testacc PKG_NAME=internal/aws/logs TESTARGS='-run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_' ACCTEST_PARALLELISM=3

TF_ACC=1 go test ./internal/aws/logs -v -count 1 -parallel 3 -run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_ -timeout 180m
=== RUN   TestAccAWSLogsLogGroup_basic
=== PAUSE TestAccAWSLogsLogGroup_basic
=== RUN   TestAccAWSLogsLogGroup_disappears
=== PAUSE TestAccAWSLogsLogGroup_disappears
=== RUN   TestAccAWSLogsLogGroup_update
=== PAUSE TestAccAWSLogsLogGroup_update
=== RUN   TestAccAWSLogsLogGroupDataSource_basic
=== PAUSE TestAccAWSLogsLogGroupDataSource_basic
=== RUN   TestAccAWSLogsLogGroupDataSource_NonExistent
=== PAUSE TestAccAWSLogsLogGroupDataSource_NonExistent
=== CONT  TestAccAWSLogsLogGroup_basic
=== CONT  TestAccAWSLogsLogGroupDataSource_basic
=== CONT  TestAccAWSLogsLogGroup_update
--- PASS: TestAccAWSLogsLogGroup_basic (26.42s)
=== CONT  TestAccAWSLogsLogGroup_disappears
--- PASS: TestAccAWSLogsLogGroupDataSource_basic (27.41s)
=== CONT  TestAccAWSLogsLogGroupDataSource_NonExistent
--- PASS: TestAccAWSLogsLogGroupDataSource_NonExistent (1.36s)
--- PASS: TestAccAWSLogsLogGroup_update (40.81s)
--- PASS: TestAccAWSLogsLogGroup_disappears (29.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-awscc/internal/aws/logs	57.130s

@johnsonaj johnsonaj marked this pull request as ready for review September 18, 2025 16:28
@johnsonaj johnsonaj requested a review from a team as a code owner September 18, 2025 16:28
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FISI! Wait, I mean LGTM 🎉

@johnsonaj johnsonaj merged commit c6f061e into main Sep 18, 2025
30 checks passed
@johnsonaj johnsonaj deleted the f-list_generator_support branch September 18, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants