Skip to content

fix: tests with the right output comment #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggallon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: tests with the right output comment #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
728e1f5
chore: update package-lock.json
ggallon May 10, 2023
a243cb5
fix: output of the expected comment
ggallon May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/__fixtures__/basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "bundle-analysis-test-fixture",
"name": "bundle-analysis-test-basic",
"version": "1.0.0",
"description": "its a test",
"main": "index.js",
Expand Down
2 changes: 1 addition & 1 deletion __tests__/__fixtures__/custom-output-directory/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "bundle-analysis-test-fixture",
"name": "bundle-analysis-test-custom-output-directory",
"version": "1.0.0",
"description": "its a test",
"main": "index.js",
Expand Down
10 changes: 9 additions & 1 deletion __tests__/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,15 @@ describe('sort of integration', () => {
),
'utf8'
)
expect(comment).toMatch(/no changes to the javascript bundle/)

// generate the output comment
const outputComment = `## 📦 Next.js Bundle Analysis for bundle-analysis-test-${dirName}

This analysis was generated by the [Next.js Bundle Analysis action](https://github.com/hashicorp/nextjs-bundle-analysis). 🤖

This PR introduced no changes to the JavaScript bundle! 🙌<!-- __NEXTJS_BUNDLE_bundle-analysis-test-${dirName} -->`

expect(comment).toMatch(outputComment)
})
})
})
Expand Down
Loading