Skip to content

fix: return lexer errors only if they affect the current cursor position#445

Open
luantranminh wants to merge 1 commit intohashicorp:mainfrom
luantranminh:main
Open

fix: return lexer errors only if they affect the current cursor position#445
luantranminh wants to merge 1 commit intohashicorp:mainfrom
luantranminh:main

Conversation

@luantranminh
Copy link
Copy Markdown

@luantranminh luantranminh commented Feb 6, 2025

Currently, when doing completion in a file that has lexer errors (like unclosed quotes), completion is not working perfectly when applying. This creates a poor user experience as users often need completion while typing incomplete code.

Example:

resource "a" {
  one {
    sr  # User wants completion here
    two {
      name = "ok  # Unclosed quote
    }
  }
}

After selecting completion item, text will append instead of replacing, causing duplication:

resource "a"  {
  one {
    ssrc  # 'src' was appended to 'sr' instead of replacing it
    two {
      name = "ok  
    }
  }
}

Expected behavior:

  • Completion should correctly replace existing text rather than appending
  • Only append completion if the lexer error affects the current cursor position

@luantranminh luantranminh requested a review from a team as a code owner February 6, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant