Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zamoore
requested review from
dchyun and
shleewhite
and
a lite review from Copilot
September 18, 2026 19:06
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation, tests, documentation, and changeset are consistent with the stated scope, with no blocking defects found.
Pull request overview
Adds four MCP prompts for selecting, implementing, reviewing, and troubleshooting Helios components using verified APIs and documentation.
Changes:
- Registers typed prompt workflows with shared validation and context handling.
- Adds integration tests for discovery, schemas, normalization, and validation.
- Updates MCP documentation and adds a changeset.
File summaries
| File | Description |
|---|---|
packages/mcp/src/prompts/*.ts |
Implements and registers the four prompts and shared helpers. |
packages/mcp/tests/integration/prompts/*.test.ts |
Covers prompt behavior and validation. |
packages/mcp/README.md |
Formats the MCP configuration example. |
.changeset/clear-components-guide.md |
Documents the new prompts. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Adds four MCP prompts to help users select, implement, review, and troubleshoot Helios components and patterns using documented guidance and resolved component APIs.
🛠️ Detailed description
choose_hds_component— recommends a component or pattern with rationale, alternatives, accessibility considerations, and a verified API starting point.implement_hds_pattern— guides clients to produce a focused Ember .gts implementation with integration test examples and explicit application-owned responsibilities.review_hds_usage— reviews supplied code for API usage, composition, and accessibility responsibilities, returning prioritized findings and suggested corrections.troubleshoot_hds_component— compares expected and observed behavior to suggest evidence-backed causes, targeted diagnostics, and minimal corrections.🔗 External links
Jira ticket: HDS-6690
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.