[Project Solar / Phase 1 / Cherry-pick] Cherry-pick updates to the HDS tokens#3948
Open
didoo wants to merge 10 commits into
Open
[Project Solar / Phase 1 / Cherry-pick] Cherry-pick updates to the HDS tokens#3948didoo wants to merge 10 commits into
didoo wants to merge 10 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Cherry-picks a set of updates to the HDS tokens package, adding new component-level token definitions (badge, badge-count, icon-tile), extending form base tokens with additional foreground/typography tokens and deprecations, and introducing a global CSS helper token for color-transform direction—along with regenerated dist/ artifacts.
Changes:
- Add new shared product token sets for
badge,badge-count, andicon-tile. - Expand
form/base-elementswith new foreground + typography tokens and mark older color tokens as deprecated. - Add a global
css.color-transform.directiontoken and a tokens packagestartwatcher script (plus dependency), regeneratingdist/outputs.
Reviewed changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks the newly added dev dependency for the tokens package watcher script. |
| packages/tokens/package.json | Adds a start script for watching token builds and adds @cnakazawa/watch. |
| packages/tokens/src/global/css.json | Introduces a global CSS helper token for color-transform direction with modes. |
| packages/tokens/src/products/shared/form/base-elements.json | Adds new form foreground + typography tokens and deprecates prior color tokens. |
| packages/tokens/src/products/shared/badge.json | Adds new badge sizing/color/typography token definitions. |
| packages/tokens/src/products/shared/badge-count.json | Adds new badge-count padding tokens. |
| packages/tokens/src/products/shared/icon-tile.json | Adds new icon-tile surface/border color tokens. |
| packages/tokens/dist/products/css/tokens.css | Regenerated CSS variables including the new tokens. |
| packages/tokens/dist/docs/products/tokens.json | Regenerated docs JSON including the new tokens. |
| packages/tokens/dist/cloud-email/tokens.scss | Regenerated Sass variables including the new global CSS token. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
…changes to the source files and rebuild
#3936 sq color direc
…ific this granularity will be used later in the “carbonization” process
20078d4 to
7683c64
Compare
dchyun
reviewed
Jun 25, 2026
dchyun
left a comment
Contributor
There was a problem hiding this comment.
Look all good to me just a couple minor things
dchyun
approved these changes
Jun 25, 2026
shleewhite
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Code cherry picked (and in some cases tweaked) from #3237
📌 Summary
There are some minor changes made to the HDS tokens in #3237 that can be cherry picked and imported directly and safely to the
mainbranch.🛠️ Detailed description
See commits descriptions for details about the changes.
🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-6480
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.