Add grpc checks support for esm.#319
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
1973cec to
936881a
Compare
|
Am interested in this, any plans for it to be merged / GRPC check to be supported in ESM? |
This is still pending review. I see there is a conflict in go.mod now which I will address. |
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| defer s.Stop() |
There was a problem hiding this comment.
defer s.Stop() executes when setUp := func(t *testing.T) *fixture returns, so the Consul test server is gone before the subtest uses runner: &CheckRunner. That makes these cases validate behavior against a dead server rather than stopExistingChecks. Please switch this to t.Cleanup(s.Stop) or keep the server on the fixture and stop it at subtest cleanup time.
There was a problem hiding this comment.
Should be resolved now, thanks for the comment!
|
Please update the PR description with appropriate details. The changes look good except for the minor comment related to test case. |
adb4214 to
8bdbaf7
Compare
Thanks @santoshpulluri , I have addressed the feedback, could you please have another look? |
santoshpulluri
left a comment
There was a problem hiding this comment.
I reviewed the latest updates. The earlier test lifecycle issue has been addressed, and the README now includes a gRPC check example. The gRPC support is integrated cleanly into the existing check runner flow, reuses Consul’s native gRPC health check implementation, and I don’t see any remaining blocking concerns. Approved.
|
@santoshpulluri thanks for the review! are there any action items on my side before it could be merged or you'll merge it on your side? |
PCI review checklist
Adding grpc health check, which is already supported in consul, to consul-esm.
Can be reverted.
NA.
Add gRPC health check support to Consul ESM: