Allow configuring NodeHealthRefreshInterval#256
Open
magec wants to merge 1 commit intohashicorp:mainfrom
Open
Conversation
|
Change looks good. Please add how have you tested it? |
Author
|
I added a test for this parameter, the same way it is done for the rest of the exported config ones (this link) . What else do you need? |
I was asking about manual tests. If you have done any? Please add in description. |
Author
|
Added some comments! |
Author
|
Any chance this could be merged? asking for a friend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on a project where several nodes come and go pretty fast, was testing
consul-esmreaping functionality an saw that the de-registering is only triggered after two health status updates, the first one that sets it to critical, and then it waits for a second one to trigger the de-registering. To speed this up I neededNodeHealthRefreshIntervalto be configurable.This change makes it configurable while maintaining the default value it had before it also adds some documentation explaining this 'use case'.
Without this, if you configure consul-esm with:
The 'non responding' node will be kept registered until 1 hour passes. Changing
node_health_refresh_intervalvalue and setting it to, let's say:will deregister the node after (at most) 5m 10s. I have personally tested this behavior.