Skip to content

Conversation

@priya-patel04
Copy link
Collaborator

@priya-patel04 priya-patel04 commented Dec 5, 2025

Description

Adds missing router service injection for sessions controller.

Screenshots (if appropriate)

Before

Screenshot 2025-12-05 at 2 28 36 PM

After

Screen.Recording.2025-12-05.at.2.40.10.PM.mov

How to Test

Navigate to sessions page and click on refresh button

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel
Copy link

vercel bot commented Dec 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Dec 5, 2025 8:41pm
boundary-ui-desktop Ready Ready Preview Comment Dec 5, 2025 8:41pm

@priya-patel04 priya-patel04 marked this pull request as ready for review December 5, 2025 20:45
@priya-patel04 priya-patel04 requested a review from a team as a code owner December 5, 2025 20:45
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

@priya-patel04 priya-patel04 merged commit 2766be2 into main Dec 5, 2025
14 of 16 checks passed
@priya-patel04 priya-patel04 deleted the session_refresh_button_fix branch December 5, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants