Icu 18007 read details #3104
Open
Icu 18007 read details #3104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sohail-hashicorp
force-pushed
the
ICU-18007-read-details
branch
from
3023c3d to
ba23582
Compare
cameronperera
requested changes
Dec 9, 2025
ui/admin/tests/integration/components/description-list/index-test.js
Outdated
Show resolved
Hide resolved
ui/admin/tests/integration/components/description-list/index-test.js
Outdated
Show resolved
Hide resolved
ui/admin/tests/integration/components/description-list/item-test.js
Outdated
Show resolved
Hide resolved
ui/admin/app/templates/scopes/scope/app-tokens/app-token/index.hbs
Outdated
Show resolved
Hide resolved
Collaborator
lisbet-alvarez
left a comment
lisbet-alvarez
left a comment
There was a problem hiding this comment.
Looking good! Just left a couple questions + suggestions
Collaborator
cameronperera
left a comment
cameronperera
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback. This looks great! I found one small display issue but I think this will be ready to go after that!
|
|
||
| return { | ||
| icon: 'grid', | ||
| text: this.intl.t('resources.scope.types.project'), |
Collaborator
There was a problem hiding this comment.
I see we are using text for the display. This is showing up as Global, Org, or Project depending on the scope level. We should be using the scope.displayName here to show the scope name or id if it has no name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a read-only details page for viewing app token information -> status, scope, TTL/TTS configuration, and usage tracking.
🎟️ Jira ticket
Screenshots (if appropriate)
How to Test
Navigate to token details
/scopes/{scope_id}/app-tokensChecklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.