Admin vite spike #3095
Admin vite spike #3095
Conversation
Convert the component helper to use static strings which are embroider safe: https://github.com/embroider-build/embroider/blob/main/docs/replacing-component-helper.md
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
ui
addons
desktop
admin
api-addon
auth-addon
styles-addon
labels
hashicc
force-pushed
the
ember-mirage
branch
from
782affb to
b0e18cb
Compare
hashicc
force-pushed
the
admin-vite-spike
branch
from
90655ef to
9febf69
Compare
| import { faker } from '@faker-js/faker'; | ||
| import { asciicasts } from './data/asciicasts'; | ||
| import { TYPE_WORKER_PKI } from 'api/models/worker'; | ||
| import environmentConfig from 'ember-get-config'; |
There was a problem hiding this comment.
Need to access the config here without this package and then restore usages to environmentConfig
|
|
||
| this.addons.forEach((addon) => { | ||
| if (addon.name === 'ember-inline-svg') addon.included(app); | ||
| // if (addon.name === 'ember-inline-svg') addon.included(app); |
There was a problem hiding this comment.
This can probably be restored
| @@ -0,0 +1 @@ | |||
| {} | |||
There was a problem hiding this comment.
There was an error failing where it expected this file to exist. Need to figure out how ember-inline-svg, or some dependency, uses this file
| "api": "workspace:*", | ||
| "core": "workspace:*", |
There was a problem hiding this comment.
api and core are used within the app so they need to be declared as dependencies
| "core": "workspace:*", | ||
| "ember-named-blocks-polyfill": "^0.2.5", | ||
| "lodash": "^4.17.21", | ||
| "miragejs": "^0.1.48", |
There was a problem hiding this comment.
miragejs should likely be a dev and peer dependency in api and then included here as a dependency
| "ember-a11y-testing": "^7.1.2", | ||
| "ember-auto-import": "^2.10.0", | ||
| "ember-basic-dropdown": "^8.8.0", | ||
| "ember-browser-services": "^4.0.3", |
There was a problem hiding this comment.
Dependencies here were brought in from other addons. They need to be declared explicitly here. They can be duplicated as dependencies here and in the addons, or the addon can declare these as peer/dev dependencies and dependencies in the apps, or (probably less preferred) hoisted to the root package.json, or pnpm catalogs
| @@ -1,232 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
There was something about this component either in app code or in this test that wasn't working
| <CopyButton | ||
| @text={{@copyText}} | ||
| @onSuccess={{this.copied}} | ||
| <div |
There was a problem hiding this comment.
ember-cli-clipboard currently has an issue with vite
1 participant
Description
Hacky spike to get admin ui to build with vite. It will load the ember app and render but there are still errors to work out
Screenshots (if appropriate)
How to Test
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.