-
Notifications
You must be signed in to change notification settings - Fork 33
chore: 🤖 bump ember-can
#3093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hashicc
wants to merge
4
commits into
main
Choose a base branch
from
bump-ember-can
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: 🤖 bump ember-can
#3093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ce93d93 to
2e18542
Compare
2e18542 to
1bf53f5
Compare
1bf53f5 to
7af504d
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump
ember-canto v8. See CHANGELOG. Version 8 ofember-canis an ember v2 addon and includes better compatibility with its peer dependencies. These changes are needed for theapiaddon to reachembroider-safecompatibility on the road to vite.There are two breaking changes that needed to be handled:
canservice was renamed toabilities, this was handled with a find/replace rename for the various discovered usage patternsextendResolversince they migrated away from using ember object and lost the reopen class api that was previously available. See Switch from an initializer to manualextendResolverusage minutebase/ember-can#186How to Test
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.