Icu 18005 UI create component ttl tts inputs #3091
Open
+363
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| @tracked days; | ||
| @tracked hours; | ||
| @tracked minutes; | ||
| @tracked data = this.createDataRow(); |
Collaborator
There was a problem hiding this comment.
does data need to be initialized if we already did so in initializeTimeFields in the constructor
| maxSeconds %= 86400; | ||
| this.hours = Math.floor(maxSeconds / 3600); | ||
| maxSeconds %= 3600; | ||
| this.minutes = Math.floor(maxSeconds / 60); |
Collaborator
There was a problem hiding this comment.
Thoughts on converting all the values used to calculate the different units of time (e.g. 86400, 3600, 60) into const vars? Since they are used more than once and it could help w/ readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a component that will be used for App Tokens. It uses 3 inputs that track a single model attribute. The component will handle the calculations and the consumer simply needs to provide the attribute and update callback.
🎟️ Jira ticket
Screenshots (if appropriate)
Screen.Recording.2025-11-24.at.3.30.28.PM.mov
How to Test
To test, you will need to pull down this branch and add the component to a form as seen in the screenshot above.
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.