Skip to content

Conversation

@hashicc
Copy link
Collaborator

@hashicc hashicc commented Nov 20, 2025

Description

This pr continues the migration away from the dynamic {{component}} helper. More information in #2880. This pull request focuses on migrating the target form component.

Screenshots (if appropriate)

How to Test

  1. Migrate to the target form and ensure it loads correctly for the different target types
  2. Tests should pass

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Nov 25, 2025 6:34pm
boundary-ui-desktop Ready Ready Preview Comment Nov 25, 2025 6:34pm

@hashicc hashicc force-pushed the migrate-component-helper-target-form branch 2 times, most recently from 70d084c to 6c63fbe Compare November 20, 2025 15:06
@hashicc hashicc force-pushed the migrate-component-helper-target-form branch 2 times, most recently from 6c63fbe to b3f8d33 Compare November 20, 2025 15:10
@hashicc hashicc force-pushed the migrate-component-helper-target-form branch from f1b8ab5 to dab21bc Compare November 24, 2025 18:03
@hashicc hashicc marked this pull request as ready for review November 24, 2025 21:37
@hashicc hashicc requested a review from a team as a code owner November 24, 2025 21:37
@hashicc hashicc force-pushed the migrate-component-helper-target-form branch from dab21bc to d9917eb Compare November 24, 2025 21:37
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants