-
Notifications
You must be signed in to change notification settings - Fork 17
chore:release - #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
themariofrancia
wants to merge
26
commits into
main
Choose a base branch
from
development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore:release - #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
β¦.ts` Signed-off-by: Mario Francia <[email protected]>
β¦ge cases and improve safety Signed-off-by: Mario Francia <[email protected]>
β¦andle edge cases and improve safety" This reverts commit ba6cb33. Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
β Snyk checks have passed. No issues have been found so far.
π» Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: jaime-iobermudez <[email protected]>
Signed-off-by: Mario Francia <[email protected]> Signed-off-by: Alberto Molina <[email protected]> Co-authored-by: Alberto Molina <[email protected]>
a3ea045 to
60f35fc
Compare
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
- Enhanced commit-msg hook to verify/auto-add DCO sign-off - Added pre-push hook as final gate requiring both DCO + GPG - Created setup-git.sh script for developer onboarding - Updated CONTRIBUTING.md with setup instructions The enforcement layers: 1. pre-commit: lint-staged for code quality 2. commit-msg: DCO verification + auto-addition + commitlint 3. pre-push: blocks push without DCO + GPG signatures Signed-off-by: Miguel_LZPF <[email protected]>
Reorganize the monolithic registry generator into a well-structured module with clear separation of concerns: Core Components: - extractor.ts: Contract metadata extraction from artifacts - scanner.ts: Filesystem scanning and contract discovery - generator.ts: Code generation logic (formerly registryGenerator.ts) - pipeline.ts: Main generation orchestration - types.ts: Centralized type definitions Utilities: - abiExtractor: ABI parsing and extraction - fileUtils: File I/O operations - logging: Structured logging - solidityParser: Comprehensive Solidity parser avoiding TypeChain Benefits: - Eliminated 6+ second TypeChain import overhead - Improved maintainability with single-responsibility modules - Better testability with isolated concerns - Flexible caching support via --use-cache flag - New npm script: npm run generate:registry:cached Infrastructure: - Updated barrel exports (index.ts files) - Cleaned up atsRegistry.data.ts (removed unused exports) - Updated CLI entry point with improved argument parsing - Enhanced logging capabilities - Updated integration tests Removed: - Old generateRegistry.ts monolithic entry point - Duplicated operations from infrastructure layer Reorganized files: - scripts/tools/generators/registryGenerator.ts β registry-generator/core/generator.ts - scripts/infrastructure/operations/generateRegistryPipeline.ts β registry-generator/pipeline.ts Signed-off-by: Miguel_LZPF <[email protected]>
Migrate from ts-node with tsconfig-paths/register to tsx for faster, simpler TypeScript script execution. Remove redundant ts-node configuration from tsconfig.json since tsx handles path aliases natively. Changes: - packages/ats/contracts/package.json: Replace all ts-node invocations with tsx in CLI entry points (deploy*, upgrade*, generate:registry) - packages/ats/contracts/tsconfig.json: Remove ts-node configuration block - package.json: Add convenience scripts for contracts utilities exposed at root level (test:scripts:unit:parallel, test:scripts:integration:parallel, upgrade:previewnet, generate:registry, local:hardhat, size, slither, doc) Benefits: - Faster script execution with tsx (no tsconfig-paths dependency) - Simpler configuration (one less configuration block) - Better IDE integration and debugging support - Scripts available directly from monorepo root for convenience Signed-off-by: Miguel_LZPF <[email protected]>
The pre-push hook was incorrectly rejecting commits that had valid GPG signatures but whose public keys were not in the local keyring. This caused pushes to fail when rebasing from branches with commits signed by other team members. Changed from `git verify-commit` (requires public key) to `git log --format=%G?` which checks if a signature EXISTS without requiring verification. The hook now accepts any signature status except 'N' (no signature). Signed-off-by: Miguel Carpena <[email protected]> Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Testing
Node version:
Checklist