-
Notifications
You must be signed in to change notification settings - Fork 84
docs: more specific backup target docs #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done.
I have major concerns about the text in the UI screenshots. It must be very clear that the backupstore stores backups, while the backup target is the endpoint used to access the backupstore. What exactly is the user configuring here?
dcf539d
to
3fd0d72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions were missed. Also, can you confirm that these changes apply only to the v1.6 doc?
Add more specific docs for configuring the backup target. This commit includes screenshots as examples, parameter explanations for both S3 and NFS type backup targets and an explanation for the refresh interval parameter. related-to: harvester/harvester#7976 Signed-off-by: Moritz Röhrich <[email protected]>
Signed-off-by: Moritz Röhrich <[email protected]>
Signed-off-by: Moritz Röhrich <[email protected]>
74a1c1e
to
5a3319d
Compare
These changes apply to the v1.6 docs only at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I asked about versions because the v1.5 doc has the same table.
Add more specific docs for configuring the backup target.
This commit includes screenshots as examples, parameter explanations for both S3 and NFS type backup targets and an explanation for the refresh interval parameter.
related-to: harvester/harvester#7976
Problem:
The refresh interval parameter for the backup target has some subtle and until now undocumented behaviors.
Additionally, the entire configuration dialogue for the backup target could be documented in greater detail.
Solution:
Add more detailed explanations for the backup target configuration, including screenshots showing examples and including all options.
Related Issue(s):
harvester/harvester#7976