-
Notifications
You must be signed in to change notification settings - Fork 84
Doc for Upgrade LogReadyTimeout setting #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done. Please check if you must update the "Default value" and "Example" sections of the documentation for this setting.
b89daf2
to
2fd3c52
Compare
@jillian-maroket thanks for pointing out. I have incorporated your suggestion as well as added default and valid values. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited the text that was added/changed since my last review.
Please confirm that no changes are to be made to the default value for the entire setting (line 768).
Signed-off-by: Dharmit Shah <[email protected]>
Signed-off-by: Dharmit Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also apply the change from 0
to 1
in the definition. Thanks!
Co-authored-by: Jillian Maroket <[email protected]> Signed-off-by: Dharmit Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Caution: The content applies to v1.7 only. Do not merge this until v1.6 is released and the v1.7 doc is created. |
Accompanying documentation PR for harvester/harvester#8421 which is opened for harvester/harvester#6855.
Related Issue(s):
harvester/harvester#6855