Skip to content

Doc for Upgrade LogReadyTimeout setting #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dharmit
Copy link
Contributor

@dharmit dharmit commented Jun 27, 2025

Accompanying documentation PR for harvester/harvester#8421 which is opened for harvester/harvester#6855.

Related Issue(s):

harvester/harvester#6855

w13915984028
w13915984028 previously approved these changes Jun 30, 2025
Copy link
Member

@w13915984028 w13915984028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done. Please check if you must update the "Default value" and "Example" sections of the documentation for this setting.

@dharmit dharmit force-pushed the logReadyTimeout branch 2 times, most recently from b89daf2 to 2fd3c52 Compare July 3, 2025 13:21
@dharmit
Copy link
Contributor Author

dharmit commented Jul 3, 2025

@jillian-maroket thanks for pointing out. I have incorporated your suggestion as well as added default and valid values.

Copy link

github-actions bot commented Jul 3, 2025

Name Link
🔨 Latest commit 750b6c5
😎 Deploy Preview https://686cc3a0214442fe90598ab0--harvester-preview.netlify.app

@dharmit dharmit force-pushed the logReadyTimeout branch from 2fd3c52 to b8dd05e Compare July 7, 2025 13:28
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the text that was added/changed since my last review.

Please confirm that no changes are to be made to the default value for the entire setting (line 768).

dharmit added 2 commits July 7, 2025 20:18
Signed-off-by: Dharmit Shah <[email protected]>
@dharmit dharmit force-pushed the logReadyTimeout branch from b8dd05e to 240fd84 Compare July 7, 2025 14:48
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also apply the change from 0 to 1 in the definition. Thanks!

Co-authored-by: Jillian Maroket <[email protected]>
Signed-off-by: Dharmit Shah <[email protected]>
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jillian-maroket
Copy link
Contributor

jillian-maroket commented Jul 8, 2025

Caution: The content applies to v1.7 only. Do not merge this until v1.6 is released and the v1.7 doc is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants